Extension - Templates in HTML format - bugs when there is , or ; in filename

Post Reply
swar
Posts: 60
Joined: 19 Dec 2020, 04:11
Name: A.R.
Location: Bratislava

Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by swar »

We have found a new bug connected with exporting records functionality in the extension.

Where: ext/templates/export_templates - HTML template (https://docs.rukovoditel.net/index.php?p=55)

What: In case there is a character , or ; in name of the file and you try to download the file, the file name extension (.docx, .pdf) in the name of the file is missing and the file cannot be opened. It seems that this bug affects only Chrome and Safari (both Windows and Mac), in Firefox it works ok.

How replicate:
1. Create an HTML template for any entity.
2. Try downloading the file. Before hitting the download button, type any name with , or ; e.g. "Confirmation from Company, Inc.".
3. Downloaded file is without extension.
4. Try downloading again without , or ; in the filename.
5. Downloaded file is fine.
User avatar
support
Site Admin
Posts: 6215
Joined: 19 Oct 2014, 18:22
Name: Sergey Kharchishin
Location: Russia, Evpatoriya

Re: Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by support »

Some browser just cut filename with special symbols because it's not supported. Just don't use it.
swar
Posts: 60
Joined: 19 Dec 2020, 04:11
Name: A.R.
Location: Bratislava

Re: Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by swar »

Would not be better to fix this problem on the level of the app by trimming these problematic characters? I guess it is about adding just a few lines of code.

We will do it in our app, but we will, unfortunately, use the changes as soon as we decide to update to a new version of Rukovoditel.

The recommendation not to use problematic characters or browsers would help in case there were no other users of the app, however, I cannot force others not to use their favourite browsers and not to type special characters.
User avatar
support
Site Admin
Posts: 6215
Joined: 19 Oct 2014, 18:22
Name: Sergey Kharchishin
Location: Russia, Evpatoriya

Re: Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by support »

ok, added in plan to fix it.
swar
Posts: 60
Joined: 19 Dec 2020, 04:11
Name: A.R.
Location: Bratislava

Re: Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by swar »

Great, thanks.
swar
Posts: 60
Joined: 19 Dec 2020, 04:11
Name: A.R.
Location: Bratislava

Re: Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by swar »

Hi Sergey, have you managed to fix this in any of new version of rukovoditel?
User avatar
support
Site Admin
Posts: 6215
Joined: 19 Oct 2014, 18:22
Name: Sergey Kharchishin
Location: Russia, Evpatoriya

Re: Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by support »

Not yet.
User avatar
support
Site Admin
Posts: 6215
Joined: 19 Oct 2014, 18:22
Name: Sergey Kharchishin
Location: Russia, Evpatoriya

Re: Extension - Templates in HTML format - bugs when there is , or ; in filename

Post by support »

This issue have been fixed for 3.3
Post Reply