CSRF vulnerability on Rukovoditel 2.8.3 Hacker change admin password

swar
Posts: 60
Joined: 19 Dec 2020, 04:11
Name: A.R.
Location: Bratislava

Re: CSRF vulnerability on Rukovoditel 2.8.3 Hacker change admin password

Post by swar »

I don't agree with that. Too many IF.
1) If you download hack file
2) If you run it.
3) if you logged
4) if you have access
then it can run some actions.
The only thing you really need to hack any Rukovoditel is to know the URL. For 1+2 it is enough to just open a link with malicious code in the browser. No need for downloading. 3 is probable as there is functionality remember me on login screen. For 4 it is enough to target admin.

If a hacker wanted to hack your personal Rukovoditel instance and knew its URL it would be enough for him to create a new thread on the forum and say "Hey Sergei, there is a bug in my Rukovoditel, I have posted a screenshot here: http://example.com/hackerswebsite/csrf_hack" You will click and if logged the attack is successful.

Or a different scenario. There are some links to systems based on Rukovoditel posted in this forum. Hacker can prepare maliciously code for any of them and them send the user PM with "I think there is a security vulnerability in your application. I have prepared a demonstration of it. Login first or the demonstration will not work and then check here: http://example.com/hackerswebsite/hacke ... /csrf_hack" Users click and hacker is in.
But I don't want to add token to all urls because it will be not possible to open item page form email notification etc.
Opening of item page is okay, IMHO there is no way how to abuse any viewing actions by this CSRF so no need to tokenized URLs. But all the edit/delete action should be protected.
User avatar
support
Site Admin
Posts: 6222
Joined: 19 Oct 2014, 18:22
Name: Sergey Kharchishin
Location: Russia, Evpatoriya

Re: CSRF vulnerability on Rukovoditel 2.8.3 Hacker change admin password

Post by support »

But all the edit/delete action should be protected.
Agree. Will add it for 2.9
User avatar
support
Site Admin
Posts: 6222
Joined: 19 Oct 2014, 18:22
Name: Sergey Kharchishin
Location: Russia, Evpatoriya

Re: CSRF vulnerability on Rukovoditel 2.8.3 Hacker change admin password

Post by support »

Done for 2.9. Now any action urls will be protect. They will have own token.
2.9 will be released at the sart of this Summer 2021.
swar
Posts: 60
Joined: 19 Dec 2020, 04:11
Name: A.R.
Location: Bratislava

Re: CSRF vulnerability on Rukovoditel 2.8.3 Hacker change admin password

Post by swar »

Very glad to hear that!

Do you think that you could upload changed files here as you usually do when preparing fixes? It would be much appreciated and believe that not only by me!
User avatar
support
Site Admin
Posts: 6222
Joined: 19 Oct 2014, 18:22
Name: Sergey Kharchishin
Location: Russia, Evpatoriya

Re: CSRF vulnerability on Rukovoditel 2.8.3 Hacker change admin password

Post by support »

At the moment it's not possible, becasue changes are in core and core already modified for 2.9.
Post Reply