Auto-increment field

[kubera]

Hi
I think that this type of field works inperfect. When the entity has no records field in form has empty value.

After saving first record (with empty value in auto-inc field) next record will be calculated as '1'

In this case there will be hole in auto-increment column.

I think that system should sets '1' for first record in entity.

[support]

Just make this field required if you don't need empty value.

[kubera]

I think that the system should propose a value by default. Even if I make this field required, value is not filled.

[support]

But for first record you can enter default value.

[kubera]

Yes but it should be set by default.

[kubera]

I fixed this for myself
In file

\includes\classes\fieldstypes\fieldtype_auto_increment.php

in line 49 replace

Code: Select all

$check_query = db_query("select (max(field_{$field['id']}+0)+1) as max_value from app_entity_{$field['entities_id']}");

to

Code: Select all

$check_query = db_query("select (COALESCE(max(field_{$field['id']}+0),0)+1) as max_value from app_entity_{$field['entities_id']}");